Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoreList for 5.41.4 #22605

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

thibaultduponchelle
Copy link
Contributor

Changes

  • Update CoreList to list module versions shipped with 5.41.4

Notes:

  • The version of CoreList is already set to 5.20240920
  • No new "utilities" shipped with 5.41.4

  • This set of changes requires a perldelta entry, and it is included.
  • This set of changes requires a perldelta entry, and I need help writing it.
  • This set of changes does not require a perldelta entry.

*perldelta entry will be generated at release time

@jkeenan
Copy link
Contributor

jkeenan commented Sep 16, 2024

This looks good ... but since the presumptive release date (Sep 20) is still four days away, can we be certain that there will be no further changes needed before then?

@thibaultduponchelle
Copy link
Contributor Author

No we are definitely not certain 😅
If some versions are modified, it will require to update CoreList again.
Can we proceed anyway? What do you think?

@jkeenan
Copy link
Contributor

jkeenan commented Sep 16, 2024

No we are definitely not certain 😅 If some versions are modified, it will require to update CoreList again. Can we proceed anyway? What do you think?

Well, you're the release manager, so ultimately it's your call. You have to choose between (a) having a committer merge this ticket now and running the risk that a module which we need to synch has a version change -- which means a new p.r. -- and (b) waiting until, say, a day before release date to have someone commit this p.r.

With great power comes ... blah, blah, blah ;-)

@thibaultduponchelle
Copy link
Contributor Author

I suggest to just keep this pull request open

@thibaultduponchelle
Copy link
Contributor Author

It's was worth the wait (Storable 3.35)

@jkeenan Now can you please consider merging 🙏🏼

@jkeenan jkeenan merged commit dfe810e into Perl:blead Sep 19, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants